Cookies, please
As my mentor suggested, I looked around in Mojo’s cookies code. I found out that the cookie parsing is pretty good tested and seems stable, well done. The cookie stringification, however, is not, so no one noticed that the to_string method doesn’t quote. The following code
$cookie = Mojo::Cookie::Response->new;
$cookie->name('foo');
$cookie->value('"bar"; Path=/baz');
leads to this cookie:
Cookie: foo="bar"; Path=/baz; Version=1
which is not what we wanted. the parser works correctly and assigns bar to the value and baz to the path value. I think, the problem sits here and here, including the following lines. It’s not only important to find failing things but test the good ones too. You can find new cookie tests on my bulletproofing branch
I know that my commit history is broken, but ATM it’s first priority for me to write tests. To make it easy to pull them into Mojo later, I’ll clean up that mess with a new fork and more branches with small patches.
